Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor l2 injection #138

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented Aug 9, 2024

This refactors the L2 source injection code in order to give it a cleaner API.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.95%. Comparing base (d4af8fd) to head (981b906).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
romanisim/image.py 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   89.95%   89.95%   -0.01%     
==========================================
  Files          17       17              
  Lines        1792     1831      +39     
==========================================
+ Hits         1612     1647      +35     
- Misses        180      184       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator Author

schlafly commented Aug 9, 2024

@zacharyburnett , sorry to bug you again, but building the wheels is failing due to failure to find a compiler? Have you seen that before? https://github.com/spacetelescope/romanisim/actions/runs/10322214023/job/28576941035?pr=138#step:7:1699

@schlafly schlafly merged commit 064ce02 into spacetelescope:main Aug 13, 2024
21 of 22 checks passed
@schlafly schlafly deleted the refactor-l2-injection branch August 13, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant