Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes following initial science validation comments. #131

Merged
merged 6 commits into from
Jul 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused variable.
  • Loading branch information
schlafly committed Jul 3, 2024
commit 6d84a75c656dca9f6eb445a0f0297638554c51f3
2 changes: 1 addition & 1 deletion romanisim/image.py
Original file line number Diff line number Diff line change
@@ -693,6 +693,7 @@ def simulate(metadata, objlist,
* sca: metadata['instrument']['detector']
* bandpass: metadata['instrument']['optical_detector']
* ma_table_number: metadata['exposure']['ma_table_number']
* read_pattern: metadata['exposure']['read_pattern']

objlist : list[CatalogObject] or Table
List of objects in the field to simulate
@@ -747,7 +748,6 @@ def simulate(metadata, objlist,
image_node['meta'] = meta
image_mod = roman_datamodels.datamodels.ImageModel(image_node)

ma_table_number = image_mod.meta.exposure.ma_table_number
filter_name = image_mod.meta.instrument.optical_element

read_pattern = metadata['exposure'].get(
Loading