Add frame zero effects. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PaulHuwe , want to take a look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 90.78% 90.94% +0.16%
==========================================
Files 17 17
Lines 1671 1701 +30
==========================================
+ Hits 1517 1547 +30
Misses 154 154 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds correlated noise across all reads associated with noise in the reference read (frame zero), which is subtracted from all subsequent reads.
A new parameter, pedestal_extra_noise, is added, with a default value of 4 DN. Noise is added to all resultants in each pixel with amplitude equal to the quadrature sum of the pixel's read noise and the extra pedestal noise.
This noise is degenerate with the pedestal and so doesn't meaningfully affect final ramp measurements at present.
We use a separate RNG so that pedestal noise can be turned on and off without affecting the rest of the random numbers in the simulation.
I also added corresponding tests.