Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bounding box, but don't use it in romanisim. #123

Merged
merged 1 commit into from
May 23, 2024

Conversation

schlafly
Copy link
Collaborator

@tddesjardins , care to see if this addresses your issue?

It's slightly annoying since by default the bounding box prevents one from figuring out, e.g., where stars land, if they land slightly off the detector. So I add a box but then disable its use within the simulator.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (525eec2) to head (fa865db).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   90.73%   90.74%   +0.01%     
==========================================
  Files          16       16              
  Lines        1630     1632       +2     
==========================================
+ Hits         1479     1481       +2     
  Misses        151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tddesjardins
Copy link
Collaborator

LGTM. I think this will do the trick. Thanks!

@schlafly schlafly marked this pull request as ready for review May 23, 2024 15:08
@schlafly schlafly requested a review from a team as a code owner May 23, 2024 15:08
@schlafly schlafly merged commit e8185a7 into spacetelescope:main May 23, 2024
19 of 20 checks passed
@schlafly schlafly deleted the bbox branch May 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants