Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-762: Simulate APT program #107

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Mar 20, 2024

Code to simulate a stack of roman images as specified by an APT program file.
Addition of a Gaia catalog generation script.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 90.69%. Comparing base (725b7cb) to head (7508f12).
Report is 10 commits behind head on main.

❗ Current head 7508f12 differs from pull request most recent head 5e407df. Consider uploading reports for the commit 5e407df to get more accurate results

Files Patch % Lines
romanisim/ris_make_utils.py 10.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   92.44%   90.69%   -1.75%     
==========================================
  Files          16       16              
  Lines        1509     1623     +114     
==========================================
+ Hits         1395     1472      +77     
- Misses        114      151      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe marked this pull request as ready for review April 18, 2024 00:07
@PaulHuwe PaulHuwe requested a review from a team as a code owner April 18, 2024 00:07
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I've left a few minor comments inline. I'd also suggest we rename the script "gaia_cat" to "romanisim-make-catalog" to be more parallel to the existing romanisim scripts installed into PATH.

scripts/gaia_cat.py Outdated Show resolved Hide resolved
scripts/gaia_cat.py Outdated Show resolved Hide resolved
scripts/gaia_cat.py Outdated Show resolved Hide resolved
scripts/gaia_cat.py Outdated Show resolved Hide resolved
@PaulHuwe PaulHuwe requested a review from schlafly April 18, 2024 15:13
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, merging.

@schlafly schlafly merged commit 1a35c0d into spacetelescope:main Apr 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants