Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-145] require Python 3.10 #106

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

zacharyburnett
Copy link
Collaborator

resolves SCSB-145

propagate Astropy's deprecation of Python 3.9 to downstream packages

Note

this PR was generated automatically by batchpr 🤖

@zacharyburnett zacharyburnett requested a review from a team as a code owner March 14, 2024 17:53
@zacharyburnett zacharyburnett self-assigned this Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (725b7cb) to head (bdc969d).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   92.44%   92.21%   -0.23%     
==========================================
  Files          16       16              
  Lines        1509     1593      +84     
==========================================
+ Hits         1395     1469      +74     
- Misses        114      124      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as draft March 14, 2024 18:31
pyproject.toml Show resolved Hide resolved
@zacharyburnett zacharyburnett marked this pull request as ready for review March 15, 2024 16:15
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schlafly
Copy link
Collaborator

Sorry, Zach, we didn't merge this back when you submitted it and now it's decayed. I tried to merge in updates and resolve the conflicts but it looks like I failed. I think the only real thing that isn't formatting that it's doing now is adding some py311 runners, but maybe I'm missing something. Can you figure out what you want to do here?

@zacharyburnett
Copy link
Collaborator Author

Sorry, Zach, we didn't merge this back when you submitted it and now it's decayed. I tried to merge in updates and resolve the conflicts but it looks like I failed. I think the only real thing that isn't formatting that it's doing now is adding some py311 runners, but maybe I'm missing something. Can you figure out what you want to do here?

sure, rebased now onto main

@schlafly schlafly merged commit 3f83fe9 into spacetelescope:main Apr 17, 2024
21 of 22 checks passed
@schlafly
Copy link
Collaborator

Thanks, merging!

@zacharyburnett zacharyburnett deleted the scsb145 branch April 18, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants