-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for Python 3.8 #155
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 8 8
Lines 1209 1209
=======================================
Hits 1185 1185
Misses 24 24 ☔ View full report in Codecov by Sentry. |
35a5d05
to
ff1823a
Compare
.readthedocs.yaml
Outdated
build: | ||
os: ubuntu-22.04 | ||
tools: | ||
python: "3.11" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RTD configuration should be redone to use mamba, see https://github.com/astropy/astropy/blob/main/.readthedocs.yaml for an example
It looks like the docs build is failing with the following:
|
d7de590
to
5b4b46d
Compare
@zacharyburnett This needs a change log entry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roman_datamodels/src/roman_datamodels/stnode.py
Lines 27 to 30 in ae1caff
if sys.version_info < (3, 9): import importlib_resources else: import importlib.resources as importlib_resources - Fix merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zacharyburnett There's now an ImportError. Once this is fixed we can merge.
|
The change request was addressed, merging. |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nadia Dencheva <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nadia Dencheva <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nadia Dencheva <[email protected]>
Numpy is imminently dropping support for Python 3.8