Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Python 3.8 #155

Merged
merged 8 commits into from
May 15, 2023
Merged

Conversation

zacharyburnett
Copy link
Collaborator

Numpy is imminently dropping support for Python 3.8

@zacharyburnett zacharyburnett requested review from a team and WilliamJamieson as code owners April 14, 2023 17:00
@zacharyburnett zacharyburnett self-assigned this Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ab475dc) 98.01% compared to head (0abbfd7) 98.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files           8        8           
  Lines        1209     1209           
=======================================
  Hits         1185     1185           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines 14 to 21
build:
os: ubuntu-22.04
tools:
python: "3.11"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RTD configuration should be redone to use mamba, see https://github.com/astropy/astropy/blob/main/.readthedocs.yaml for an example

.readthedocs.yaml Outdated Show resolved Hide resolved
@zacharyburnett
Copy link
Collaborator Author

It looks like the docs build is failing with the following:
https://readthedocs.org/projects/roman-datamodels/builds/20119428/

/home/docs/checkouts/readthedocs.org/user_builds/roman-datamodels/checkouts/155/docs/roman_datamodels/datamodels/developer_api.rst:113: WARNING: autosummary: stub file not found 'roman_datamodels.stuserdict.Any'. Check your autosummary_generate setting.

@nden
Copy link
Collaborator

nden commented Apr 18, 2023

@nden
Copy link
Collaborator

nden commented Apr 24, 2023

@zacharyburnett This needs a change log entry

Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden
Copy link
Collaborator

nden commented May 15, 2023

@zacharyburnett There's now an ImportError. Once this is fixed we can merge.

"datamodels-1.0.yaml"
E NameError: name 'importlib_resources' is not defined

@nden nden requested a review from WilliamJamieson May 15, 2023 12:33
@nden
Copy link
Collaborator

nden commented May 15, 2023

The change request was addressed, merging.

@nden nden merged commit d51dfac into spacetelescope:main May 15, 2023
@zacharyburnett zacharyburnett deleted the drop_py38 branch May 15, 2023 12:37
mairanteodoro pushed a commit to mairanteodoro/roman_datamodels that referenced this pull request May 22, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nadia Dencheva <[email protected]>
mairanteodoro pushed a commit to mairanteodoro/roman_datamodels that referenced this pull request May 23, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nadia Dencheva <[email protected]>
zacharyburnett added a commit to mairanteodoro/roman_datamodels that referenced this pull request May 25, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nadia Dencheva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants