Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'data_dir' to 'working_data_dir' for dark monitor #1460

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

york-stsci
Copy link
Collaborator

This fixes a bug in the dark monitor where, in two places, data_dir was not updated to working_data_dir.

@york-stsci
Copy link
Collaborator Author

I'm sorry, I accidentally did this as a branch in the main repository rather than as a branch in my fork. Hopefully that won't cause any problems.

@york-stsci york-stsci self-assigned this Jan 31, 2024
@york-stsci york-stsci added the bug label Jan 31, 2024
@york-stsci york-stsci linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple of instances where the data_dir -> working_data_dir were missed previously?

@york-stsci
Copy link
Collaborator Author

Correct. I think this one is mercifully easy and ready to go.

@mfixstsci mfixstsci merged commit 8ce877a into develop Feb 5, 2024
11 checks passed
Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark monitor attempts to use nonexistent "data_dir" attribute
3 participants