imviz matched zoom: use center & radius instead of corners

[kecnry]

Description

This pull request fixes matched image box zoom when the matched viewers have different aspect ratios.'

TODO: this breaks the old tests that expect the same limits to be returned

Before:

Screen.Recording.2024-10-08.at.1.10.41.PM.mov

After:

Screen.Recording.2024-10-08.at.1.10.02.PM.mov

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[bmorris3]

This looks better! I will test on Rampviz later, just wanted to log that this implementation looks good to me.

[kecnry]

Looks like there is still jittering in Rampviz with 3 viewers (but not with 2 viewers or Imviz with 3 viewers)... will continue to investigate and see if I can find a more general solution 🤞

[bmorris3]

Woah! This looks a lot better now. There's still >1 zoom reset happening in the matched viewers, but it's happening really fast for me now.

Thank you!

[kecnry]

Oh I forgot I still need to update tests 🤦‍♂️ I'll put in draft and work on that - glad to hear it seems to have fixed the use-case though!

[rosteen]

I also confirmed that it fixed the behavior I was seeing in Rampviz, I'll do a more thorough review once you update the tests.

[kecnry]

Requires #3222 to pass remaining failing tests

[bmorris3]

Test revisions make sense. Thanks!

[rosteen]

Agreed, looks fine.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (0133d7d) to head (cca2396).
Report is 113 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3215      +/-   ##
==========================================
+ Coverage   88.56%   88.62%   +0.05%     
==========================================
  Files         125      125              
  Lines       18758    18775      +17     
==========================================
+ Hits        16613    16639      +26     
+ Misses       2145     2136       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.