-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New color Imviz logo from Jenn #2109
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 91.92% 91.90% -0.02%
==========================================
Files 143 143
Lines 15602 15605 +3
==========================================
Hits 14342 14342
- Misses 1260 1263 +3 see 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs rendered fine. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the png used anywhere? Do we care about the change in resolution?
Hmm seems like for some reason, only Imviz has two different file formats. I am not sure. |
I don't think the PNG logos are currently used anywhere. Currently each SVG has a PNG alongside it, which is handy if you're importing the graphic to an app that doesn't support SVG. Not strictly necessary for us though. 🤷🏻 |
@bmorris3 didn't add any new files though, so if we cannot decide now, we can punt this as tech debt for the future to remove duplicate PNG. Up to you. |
I'll do that. Thanks all! 🐱 |
Thanks, @Jenneh ! |
Description
Jenn has contributed a multi-color version of the Imviz logo.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.