Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New color Imviz logo from Jenn #2109

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Mar 22, 2023

Description

Jenn has contributed a multi-color version of the Imviz logo.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@bmorris3 bmorris3 added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 22, 2023
@bmorris3 bmorris3 added this to the 3.4 milestone Mar 22, 2023
@github-actions github-actions bot added the documentation Explanation of code and concepts label Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (5a4d2e3) 91.92% compared to head (c46b6d8) 91.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   91.92%   91.90%   -0.02%     
==========================================
  Files         143      143              
  Lines       15602    15605       +3     
==========================================
  Hits        14342    14342              
- Misses       1260     1263       +3     

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rosteen rosteen modified the milestones: 3.4, 3.5 Mar 22, 2023
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs rendered fine. Thanks!

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the png used anywhere? Do we care about the change in resolution?

@pllim
Copy link
Contributor

pllim commented Mar 22, 2023

Hmm seems like for some reason, only Imviz has two different file formats. I am not sure.

@bmorris3
Copy link
Contributor Author

Is the png used anywhere? Do we care about the change in resolution?

I don't think the PNG logos are currently used anywhere. Currently each SVG has a PNG alongside it, which is handy if you're importing the graphic to an app that doesn't support SVG. Not strictly necessary for us though. 🤷🏻

@pllim
Copy link
Contributor

pllim commented Mar 22, 2023

@bmorris3 didn't add any new files though, so if we cannot decide now, we can punt this as tech debt for the future to remove duplicate PNG. Up to you.

@bmorris3
Copy link
Contributor Author

bmorris3 commented Mar 22, 2023

punt this as tech debt for the future to remove duplicate PNG

I'll do that. Thanks all! 🐱

@bmorris3 bmorris3 merged commit 5510486 into spacetelescope:main Mar 22, 2023
@pllim
Copy link
Contributor

pllim commented Mar 22, 2023

Thanks, @Jenneh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants