Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump glue-astronomy to 0.7, max pin ipywidgets #2105

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Mar 21, 2023

Description

This pull request bumps the minimum version of glue-astronomy to 0.7 to get updates to units that prevents an error in specviz when loading multiple spectra.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

* fixes support for multiple spectra in specviz without UnitConversionError
@kecnry kecnry added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Mar 21, 2023
@kecnry kecnry added this to the 3.4 milestone Mar 21, 2023
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a new CI job to test against oldest supported dependencies but that is a battle for another day... Thanks!

@pllim
Copy link
Contributor

pllim commented Mar 21, 2023

LoL wut? NotImplementedError: Cannot

@rosteen
Copy link
Collaborator

rosteen commented Mar 21, 2023

Oh no, I thought that error would be unique to #2104 but I guess not 😬

@pllim
Copy link
Contributor

pllim commented Mar 21, 2023

I opened upstream issue at jupyter-widgets/ipywidgets#3729 . For now, I think we need to max pin ipywidgets to 8.0.4

@pllim
Copy link
Contributor

pllim commented Mar 21, 2023

ipywidgets dev suggested a simple workaround: jupyter-widgets/ipywidgets#3729 (comment)

@rosteen
Copy link
Collaborator

rosteen commented Mar 21, 2023

We might need to add that import to every affected test file 😬

@pllim
Copy link
Contributor

pllim commented Mar 21, 2023

import to every affected test file

That sounds painful... I'd rather not.

@pllim pllim changed the title bump glue-astronomy to 0.7 bump glue-astronomy to 0.7, max pin ipywidgets Mar 21, 2023
@pllim pllim merged commit 9a4febd into spacetelescope:main Mar 21, 2023
@pllim
Copy link
Contributor

pllim commented Mar 21, 2023

I opened follow-up issue at #2103

@kecnry kecnry deleted the bump-glue-astro branch March 21, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants