-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump glue-astronomy to 0.7, max pin ipywidgets #2105
Conversation
* fixes support for multiple spectra in specviz without UnitConversionError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need a new CI job to test against oldest supported dependencies but that is a battle for another day... Thanks!
LoL wut? |
Oh no, I thought that error would be unique to #2104 but I guess not 😬 |
I opened upstream issue at jupyter-widgets/ipywidgets#3729 . For now, I think we need to max pin ipywidgets to 8.0.4 |
ipywidgets dev suggested a simple workaround: jupyter-widgets/ipywidgets#3729 (comment) |
We might need to add that import to every affected test file 😬 |
That sounds painful... I'd rather not. |
I opened follow-up issue at #2103 |
Description
This pull request bumps the minimum version of glue-astronomy to 0.7 to get updates to units that prevents an error in specviz when loading multiple spectra.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.