Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: aperture sum counted npix twice #1332

Merged
merged 1 commit into from
May 24, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 19, 2022

Description

This pull request is to fix a bug where aperture sum counted npix twice when converting from MJy/sr to MJy. Thanks to @orifox for finding this bug and @larrybradley for the fix suggestion!

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

when converting from MJy/sr to MJy
@pllim pllim added bug Something isn't working 🔥 Critical labels May 19, 2022
@pllim pllim added this to the 2.6 milestone May 19, 2022
@pllim pllim requested review from larrybradley and orifox May 19, 2022 21:15
@github-actions github-actions bot added documentation Explanation of code and concepts imviz labels May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1332 (2e58202) into main (12d97b8) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
+ Coverage   84.60%   84.77%   +0.16%     
==========================================
  Files          91       91              
  Lines        7836     7835       -1     
==========================================
+ Hits         6630     6642      +12     
+ Misses       1206     1193      -13     
Impacted Files Coverage Δ
...imviz/plugins/aper_phot_simple/aper_phot_simple.py 91.52% <100.00%> (-0.03%) ⬇️
...s/default/plugins/model_fitting/fitting_backend.py 93.02% <0.00%> (+15.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d97b8...2e58202. Read the comment docs.

@orifox
Copy link
Contributor

orifox commented May 24, 2022

All the new numbers match mine. I approve. :)

@pllim pllim merged commit dcebb9a into spacetelescope:main May 24, 2022
@pllim pllim deleted the apersum-mjysr-conv branch May 24, 2022 15:14
@pllim
Copy link
Contributor Author

pllim commented May 24, 2022

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Explanation of code and concepts 🔥 Critical imviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants