Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize CubeFactory classes #143

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Generalize CubeFactory classes #143

wants to merge 6 commits into from

Conversation

snbianco
Copy link
Collaborator

@snbianco snbianco commented Feb 19, 2025

Generalizing the cube factory classes so that TicaCubeFactory is a child of CubeFactory.

A few considerations:

  • This is not completely "general" in that the parent CubeFactory class is built for SPOC FFIs. Unfortunately, we can't do much about this without changing the existing API entirely. I did my best to factor all of the TESS-specific content into variables and methods that can be easily overridden in future child classes.
  • The tests were kept largely the same, but I did add some assertions and restructured things a bit.
  • There was some code in _update_info_table that was opening FITS files within a loop. I fixed this to only open the files once.
  • I moved the logic for update_cube into CubeFactory (when it was originally just in TicaCubeFactory) and renamed the method to be public.

@snbianco snbianco marked this pull request as ready for review February 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant