Generalize CubeFactory classes #143
Open
+1,001
−1,096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizing the cube factory classes so that
TicaCubeFactory
is a child ofCubeFactory
.A few considerations:
CubeFactory
class is built for SPOC FFIs. Unfortunately, we can't do much about this without changing the existing API entirely. I did my best to factor all of the TESS-specific content into variables and methods that can be easily overridden in future child classes._update_info_table
that was opening FITS files within a loop. I fixed this to only open the files once.update_cube
intoCubeFactory
(when it was originally just inTicaCubeFactory
) and renamed the method to be public.