PR 180 + pllim edits #183
Merged
PR 180 + pllim edits #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
commented
Oct 31, 2023
acstools/focus_diverse_epsfs.py
Outdated
| @@ -0,0 +1,460 @@ | |||
| """This module contains two functions that provide | |||
| means to programmatically query the `ACS/WFC | |||
| Focus-Diverse ePSF Generator <acspsf.stsci.edu>`_ API. | |||
There was a problem hiding this comment.
https://acspsf.stsci.edu does not work. Is this a real URL?
There was a problem hiding this comment.
this URL will be set to live once the module is available on acstools
There was a problem hiding this comment.
OK, chicken and egg then. I guess we can merge ignoring the failing link check job.
|
"Python 3.12 with remote data" (devdeps) job failure is unrelated. |
jryon
requested changes
Oct 31, 2023
|
@gsanand , can you also please respond to this question from Jenna?
|
it looks like they print to the screen |
pllim
commented
Nov 7, 2023
to clarify this option
yotam-stsci
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my edits on top of #180 by @gsanand . I was working off his branch that was already rebased on top of latest master (his original branch was outdated). And then realized too late I cannot easily open a PR to his PR in that state. And GitHub (rightfully) refused to let me force push to his fork's master branch, which he created the PR from (not recommended to create PR from fork's master but that is neither here nor there...).
Please review, @gsanand and @jryon . There are some things I am not sure about, search for "FIXME" in my diff to see them.