Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the skimage.morphology.remove_small_objects() function in satdet.py. #177

Merged
merged 1 commit into from
May 17, 2023

Conversation

annierose3
Copy link
Contributor

Description

This pull request is to address an error that pops up due to a newer version of scikit-image. The new version has deprecated "in_place" in favor of "out" in the skimage.morphology.remove_small_objects() function.

 A newer version of scikit-image has deprecated in_place in favor of out in the skimage.morphology.remove_small_objects() function.
@pllim
Copy link
Collaborator

pllim commented May 17, 2023

LGTM though someone from ACS Team should approve, maybe @jryon or @dvstark ?

Copy link
Contributor

@jryon jryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me.

@jryon jryon merged commit f8e8ce3 into spacetelescope:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants