incorporate findsat_mrt into acstools

[dvstark]

Description

This pull request is incorporate newcode (findsat_mrt) into acstools. This code, described in ISR 2022-08, provides a new framework for identifying and masking satellite trails in ACS/WFC data. It should not impact any existing acstools programs.

[dvstark]

I'm aware of the odd line breaks with ^M at the end, and am trying to fix it

[pllim]

I have a bunch of proposed changes over at dvstark#1 . These include API changes and bug fixes as we discussed on Slack. I also applied changes from my earlier rounds of reviews. Reading the diff might drive you crazy, so it might be better for you to view the before/after side by side.

Since these include real bug fixes, if you run the unit test that you wrote with my changes, the result now disagrees with the "truth" you provided here. I cannot tell if that is okay or not, so please look at it carefully.

We can discuss via meeting the week after next if you are unable to review it on your own. Thank you for your continued patience!

[pllim]

A minor PEP 8 thingy to fix.

And also the link appears broken: https://www.clear.rice.edu/elec431/projects96/DSP/bpanalysis.html

[dvstark]

I'm suspecting that broken link was temporary; it seems to be working now. I'll fix the pep8 stuff and push again

[pllim]

Just some minor comments. I'll approve when they are addressed.

By the way, CI was green after I reran the failed jobs, so the linkcheck and socket failures were indeed transient.

[dvstark]

All your suggested changes made sense so I committed them all (and sorry if this led to various email notifications from github after every commit)

[pllim]

Thanks! @jryon , do you want to re-review since you requested changes?

If you happen to merge first, please use the Squash and Merge button.

[jryon]

I'm happy with it now that @pllim and @dvstark are!

[pllim]

Merged. Congrats and thanks for your patience!

@jryon , you are doing releases now, right?

[jryon]

Yep, added to my to-do list.

[dvstark]

Thanks both!