Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Use bitmask from astropy>=3.1 #124

Merged
merged 1 commit into from
Apr 28, 2020
Merged

MNT: Use bitmask from astropy>=3.1 #124

merged 1 commit into from
Apr 28, 2020

Conversation

pllim
Copy link
Collaborator

@pllim pllim commented Apr 27, 2020

Fix #123

cc @mcara and @jdavies-st

@pllim pllim requested a review from jryon April 27, 2020 18:30
@jryon
Copy link
Contributor

jryon commented Apr 27, 2020

I tested the new imports by running acs_destripe.clean and acs_destripe_plus.destripe_plus on some test data, and found no issues.

@mcara
Copy link
Member

mcara commented Apr 27, 2020 •
edited
Loading

@jryon Thank you!

@pllim pllim merged commit e1a0731 into spacetelescope:master Apr 28, 2020
@pllim pllim deleted the astropy-bitmask branch April 28, 2020 01:45
@pllim
Copy link
Collaborator Author

pllim commented Apr 28, 2020

Thanks for the review, @jryon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryon jryon jryon approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interpret_bit_flags should be imported from astropy.nddata.bitmask
3 participants
@pllim @jryon @mcara