[Merged by Bors] - Add check if ATXv2 is live already for malsync #6715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
dshulyak,
poszu,
ivan4th,
jellonek and
kacpersaw
as code owners
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6715 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.1%
=========================================
Files 366 366
Lines 49989 49999 +10
=========================================
- Hits 39941 39926 -15
- Misses 7789 7812 +23
- Partials 2259 2261 +2 ☔ View full report in Codecov by Sentry. |
fasmat
force-pushed
the
enable-mal2-in-first-atxv2-epoch
branch
from
53f103f to
d6e2559
Compare
poszu
approved these changes
Feb 11, 2025
Created an issue #6716 and added a TODO to the code referencing it. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
fasmat
added a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
4 tasks
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
fasmat
added a commit
that referenced
this pull request
Feb 11, 2025
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Canceled. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
## Motivation This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
Description
Nodes that already run the new version of malfeasance sync get stuck if not enough peers also run a version of the node already that understands malfeasance v2. This PR updates the malfeasance sync to not start until ATXv2 goes live. By then most nodes should have upgraded to a version that supports the new sync protocol and no node should get stuck because of missing peers to sync from.
Test Plan
TODO