[Merged by Bors] - Split two balance-related errors #5820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to wait for #5807 to be merged before fixing the vm_test errors here as there will be a merge conflict otherwise. |
lrettig
force-pushed
the
split-gas-errors
branch
from
4b79ff9 to
9f9db45
Compare
Make the distinction a bit clearer between cases where there's not enough funds to send vs. not enough to cover gas metering.
lrettig
force-pushed
the
split-gas-errors
branch
from
9f9db45 to
50ad90c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5820 +/- ##
=======================================
Coverage 80.4% 80.4%
=======================================
Files 283 283
Lines 29282 29282
=======================================
+ Hits 23558 23559 +1
+ Misses 4132 4131 -1
Partials 1592 1592 ☔ View full report in Codecov by Sentry. |
lrettig
requested review from
dshulyak,
fasmat,
poszu and
ivan4th
as code owners
fasmat
approved these changes
Apr 11, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Make the distinction a bit clearer between cases where there's not enough funds to send vs. not enough to cover gas metering. ## Motivation Just makes errors clearer
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
poszu
pushed a commit
that referenced
this pull request
Apr 15, 2024
Make the distinction a bit clearer between cases where there's not enough funds to send vs. not enough to cover gas metering. ## Motivation Just makes errors clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the distinction a bit clearer between cases where there's not enough funds to send vs. not enough to cover gas metering.
Motivation
Just makes errors clearer
Description
Self-explanatory
Test Plan
Existing tests updated, no need for new tests
TODO