[Merged by Bors] - p2p: add spread to the discovery advertisement interval

[ivan4th]

Motivation

Need to lessen DHT overload from the routing discovery mechanism

Description

Default to 2h +/- 1h discovery advertisement interval

Test Plan

Verified on a mainnet node

[codecov]

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.2%. Comparing base (4cd82fd) to head (8d5f0e6).

Files	Patch %	Lines
p2p/host.go	71.4%	1 Missing and 1 partial ⚠️
p2p/dhtdiscovery/discovery.go	88.8%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5815     +/-   ##
=========================================
- Coverage     80.2%   80.2%   -0.1%     
=========================================
  Files          286     286             
  Lines        29804   29815     +11     
=========================================
- Hits         23930   23919     -11     
- Misses        4219    4240     +21     
- Partials      1655    1656      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fasmat]

Instead of making this configurable would it make sense to instead have it a relative amount, e.g. 1%?

[pigmej]

bors merge

[spacemesh-bors]

Build failed (retrying...):

• systest-status

[spacemesh-bors]

Build failed:

• systest-status

[ivan4th]

bors merge

[ivan4th]

systests timed out with rather unclear reason, retrying

[spacemesh-bors]

Timed out.

[ivan4th]

Timed out on this job: CI / build-tools (go-spacemesh, m2-pro) (push)

[ivan4th]

bors merge

[spacemesh-bors]

Build failed (retrying...):

• ci-status

[ivan4th]

Test flake on Windows:

    grpcserver_test.go:759: 
        	Error Trace:	D:/a/go-spacemesh/go-spacemesh/api/grpcserver/grpcserver_test.go:759
        	Error:      	An error is expected but got nil.
        	Test:       	TestSmesherService/PostSetupStatusStream
    logger.go:146: 2024-04-09T15:31:53.496Z	INFO	grpc	finished streaming call with code OK	{"grpc.start_time": "2024-04-09T15:31:53Z", "system": "grpc", "span.kind": "server", "grpc.service": "spacemesh.v1.SmesherService", "grpc.method": "PostSetupStatusStream", "peer.address": "127.0.0.1:65112", "grpc.code": "OK", "grpc.time_ms": 50.828}
    logger.go:146: 2024-04-09T15:31:53.498Z	INFO	grpc	stopping the grpc server
--- FAIL: TestSmesherService/PostSetupStatusStream (1.11s)

[fasmat]

bors merge

[spacemesh-bors]

Merge conflict.

[ivan4th]

bors merge

[spacemesh-bors]

Pull request successfully merged into develop.

Build succeeded:

• systest-status
• ci-status