[Merged by Bors] - Use random port for post service in supervised mode #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5731 +/- ##
=========================================
- Coverage 80.1% 80.0% -0.1%
=========================================
Files 279 279
Lines 29021 29032 +11
=========================================
+ Hits 23246 23248 +2
- Misses 4179 4186 +7
- Partials 1596 1598 +2 ☔ View full report in Codecov by Sentry. |
|
bors try |
tryBuild failed: |
ivan4th
reviewed
Mar 19, 2024
|
bors try |
ivan4th
approved these changes
Mar 19, 2024
tryBuild failed: |
spacemesh-bors
bot
changed the base branch from
fix-signer-file-not-set-on-generate
to
develop
fasmat
force-pushed
the
random-port-supervised-post-service
branch
from
24ffcca to
ce18462
Compare
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
## Motivation In supervised mode the node should just pick a random port for post service by default to ensure that the connection of the service actually uses a free port on the system. This PR requires #5730 to be merged for a bug fix first.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In supervised mode the node should just pick a random port for post service by default to ensure that the connection of the service actually uses a free port on the system.
This PR requires #5730 to be merged for a bug fix first.
Description
The default port for
PostListenerhas been changed to127.0.0.1:0effectively assigning a random (free) port to be used by the node and the post service for their communication.To make this happen some code had to be re-arranged such that after starting the grpc server for the
PostListenerthe node passes the bound address to the Smesher GRPC service (so it can use start/stop smeshing) and then checks if it is in supervised mode or not.Test Plan
TODO