[Merged by Bors] - Flaky test TestRewardService_List/coinbase #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpersaw
requested review from
dshulyak,
fasmat,
poszu and
ivan4th
as code owners
kacpersaw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5680 +/- ##
=========================================
+ Coverage 79.7% 79.8% +0.1%
=========================================
Files 279 279
Lines 28419 28426 +7
=========================================
+ Hits 22670 22705 +35
+ Misses 4181 4154 -27
+ Partials 1568 1567 -1 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Mar 11, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
## Motivation This change fixes problem with test flakiness. RewardsGenerator was changed to generate rewards with unique coinbases to avoid problem with order of data between DB and generated list of rewards.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
## Motivation This change fixes problem with test flakiness. RewardsGenerator was changed to generate rewards with unique coinbases to avoid problem with order of data between DB and generated list of rewards.
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
## Motivation This change fixes problem with test flakiness. RewardsGenerator was changed to generate rewards with unique coinbases to avoid problem with order of data between DB and generated list of rewards.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
## Motivation This change fixes problem with test flakiness. RewardsGenerator was changed to generate rewards with unique coinbases to avoid problem with order of data between DB and generated list of rewards.
|
Build failed (retrying...): |
|
bors cancel |
|
Canceled. |
4 tasks
…strewardservice_listcoinbase
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
## Motivation This change fixes problem with test flakiness. RewardsGenerator was changed to generate rewards with unique coinbases to avoid problem with order of data between DB and generated list of rewards. Co-authored-by: Matthias <[email protected]>
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
spacemesh-bors
bot
deleted the
5636-flaky-test-testrewardservice_listcoinbase
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change fixes problem with test flakiness.
RewardsGenerator was changed to generate rewards with unique coinbases to avoid problem with order of data between DB and generated list of rewards.