Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Prioritize verifying own POST #5417

Closed
wants to merge 6 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jan 9, 2024

Motivation

When there is a lot of ATX to handle, the self-published ATX might get stuck in the POST verification queue.

Changes

  • prioritize verifying your own POST by processing it synchronously (bypassing scheduling on the worker pool).

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66de030) 77.4% compared to head (aefeb6b) 77.5%.
Report is 2 commits behind head on develop.

❗ Current head aefeb6b differs from pull request most recent head bf2d9c5. Consider uploading reports for the commit bf2d9c5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #5417   +/-   ##
=======================================
  Coverage     77.4%   77.5%           
=======================================
  Files          265     265           
  Lines        30891   30920   +29     
=======================================
+ Hits         23931   23968   +37     
+ Misses        5438    5432    -6     
+ Partials      1522    1520    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu
Copy link
Contributor Author

poszu commented Jan 9, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jan 9, 2024
activation/post_verifier.go Outdated Show resolved Hide resolved
activation/post_verifier.go Outdated Show resolved Hide resolved
@spacemesh-bors
Copy link

spacemesh-bors bot commented Jan 9, 2024

try

Build failed:

@poszu poszu requested a review from fasmat January 10, 2024 12:32
@poszu
Copy link
Contributor Author

poszu commented Jan 10, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jan 10, 2024
@spacemesh-bors
Copy link

try

Build succeeded:

@poszu
Copy link
Contributor Author

poszu commented Jan 10, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jan 10, 2024
@spacemesh-bors
Copy link

try

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Jan 11, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jan 11, 2024
## Motivation
When there is a lot of ATX to handle, the self-published ATX might get stuck in the POST verification queue.

## Changes
- prioritize verifying your own POST by processing it synchronously (bypassing scheduling on the worker pool).
- removed workaround that disabled post verifying worker pool scaling in systests
@spacemesh-bors
Copy link

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Jan 11, 2024
## Motivation
When there is a lot of ATX to handle, the self-published ATX might get stuck in the POST verification queue.

## Changes
- prioritize verifying your own POST by processing it synchronously (bypassing scheduling on the worker pool).
- removed workaround that disabled post verifying worker pool scaling in systests
@spacemesh-bors
Copy link

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Jan 12, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jan 12, 2024
@spacemesh-bors
Copy link

try

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Jan 12, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jan 12, 2024
@spacemesh-bors
Copy link

try

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Jan 12, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jan 12, 2024
## Motivation
When there is a lot of ATX to handle, the self-published ATX might get stuck in the POST verification queue.

## Changes
- prioritize verifying your own POST by processing it synchronously (bypassing scheduling on the worker pool).
- removed workaround that disabled post verifying worker pool scaling in systests
@poszu
Copy link
Contributor Author

poszu commented Jan 12, 2024

bors cancel

@spacemesh-bors
Copy link

Canceled.

@poszu
Copy link
Contributor Author

poszu commented Jan 12, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jan 12, 2024
@spacemesh-bors
Copy link

try

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Jan 15, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jan 15, 2024
@spacemesh-bors
Copy link

try

Build succeeded:

@poszu
Copy link
Contributor Author

poszu commented Jan 15, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jan 15, 2024
## Motivation
When there is a lot of ATX to handle, the self-published ATX might get stuck in the POST verification queue.

## Changes
- prioritize verifying your own POST by processing it synchronously (bypassing scheduling on the worker pool).
- removed workaround that disabled post verifying worker pool scaling in systests
@spacemesh-bors
Copy link

Build failed:

@poszu
Copy link
Contributor Author

poszu commented Jan 15, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jan 15, 2024
## Motivation
When there is a lot of ATX to handle, the self-published ATX might get stuck in the POST verification queue.

## Changes
- prioritize verifying your own POST by processing it synchronously (bypassing scheduling on the worker pool).
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Prioritize verifying own POST [Merged by Bors] - Prioritize verifying own POST Jan 15, 2024
@spacemesh-bors spacemesh-bors bot closed this Jan 15, 2024
@spacemesh-bors spacemesh-bors bot deleted the prioritize-handling-own-atx branch January 15, 2024 16:06
poszu added a commit that referenced this pull request Jan 16, 2024
When there is a lot of ATX to handle, the self-published ATX might get stuck in the POST verification queue.

- prioritize verifying your own POST by processing it synchronously (bypassing scheduling on the worker pool).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants