-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - setup min activeset weight with data from latest epoch #5171
[Merged by Bors] - setup min activeset weight with data from latest epoch #5171
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5171 +/- ##
==========================================
+ Coverage 0 77.6% +77.6%
==========================================
Files 0 261 +261
Lines 0 30995 +30995
==========================================
+ Hits 0 24082 +24082
- Misses 0 5407 +5407
- Partials 0 1506 +1506
|
MinimalActiveSetWeight: []types.EpochMinimalActiveWeight{ | ||
{Weight: 1_000_000}, | ||
// generated using ./cmd/activeset for publish epoch 6 | ||
// it will be used starting from epoch 8, because we will only release it in 7th | ||
{Epoch: 8, Weight: 7_879_129_244}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this list expected to be small? If it's going to have an entry per every epoch, then perhaps using something like a btree would be beneficial (for faster lookup in Select()
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is expected to be small. min activeset value is only needed to compute eligibilities in the current epoch. for previous epochs we store a counter. there are two values so that we can update in the middle of the epoch, likely it will be at most 2 in any release
bors merge |
closes: #5137 - added a tool that can be used to read db and compute total weight of atxs in the latest epoch - activeset weight configured as a sorted array of tuples (epoch, weight). components select latest tuple that match epoch based on timing of usage
Build failed: |
bors merge |
closes: #5137 - added a tool that can be used to read db and compute total weight of atxs in the latest epoch - activeset weight configured as a sorted array of tuples (epoch, weight). components select latest tuple that match epoch based on timing of usage
Build failed:
|
bors merge |
closes: #5137 - added a tool that can be used to read db and compute total weight of atxs in the latest epoch - activeset weight configured as a sorted array of tuples (epoch, weight). components select latest tuple that match epoch based on timing of usage
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
closes: #5137