Allow to pass a custom fuzzing function to FuzzConsistency #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dshulyak
approved these changes
Mar 27, 2023
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Mar 27, 2023
…ethods (#4209) ## Motivation We should have fuzzing tests for all types with handwritten `EncodeScale` and `DecodeScale` methods. This will protect us from changes to any type that doesn't have generated methods and might lead to bugs that wouldn't otherwise be detected. Do not merge before: spacemeshos/go-scale#53 ## Changes Add fuzzing tests for all types with handwritten `EncodeScale` and `DecodeScale` methods. ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this we cannot run
testing.FuzzConsistencyon types that have embedded interfaces (see common/types/malfeasance_test.go in this PR: spacemeshos/go-spacemesh#4209)