v2alpha1: add network service #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
reviewed
Mar 20, 2024
spacemesh/v2alpha1/network.proto
Outdated
| } | ||
|
|
||
| service NetworkService { | ||
| rpc Info(google.protobuf.Empty) returns (NetworkInfoResponse); |
There was a problem hiding this comment.
How about using an empty message NetworkInfoRequest {} type instead? The advantage is that it could be later extended without breaking compatibility (in protobuf you can add new fields, but cannot change the type). IDK if it ever makes sense to pass anything in this request but it doesn't harm to be prepared.
spacemesh/v2alpha1/network.proto
Outdated
| package spacemesh.v2alpha1; | ||
|
|
||
| message NetworkInfoResponse { | ||
| uint64 genesis_time = 1; // network genesis time as unix epoch time |
There was a problem hiding this comment.
Why not use the Timestamp from the well-known-types?
spacemesh/v2alpha1/network.proto
Outdated
|
|
||
| message NetworkInfoResponse { | ||
| uint64 genesis_time = 1; // network genesis time as unix epoch time | ||
| uint32 layer_duration = 3; // layer duration, in seconds |
There was a problem hiding this comment.
Here you could use Duration from the WKT.
poszu
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API v2 spec #300
Add new network service for v2alpha1 based on API v2 spec.