Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an info box #610

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added an info box #610

wants to merge 2 commits into from

Conversation

maxehio
Copy link
Contributor

@maxehio maxehio commented Sep 2, 2024

Description of the change

I added another "Administrative stacks get the Admin role in the space they belong to" info box to the stack settings document under the Administrative section. This addition is relevant and could be easily overlooked if no one reads the space access control document.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

Copy link

render bot commented Sep 2, 2024

@maxehio maxehio requested a review from a team September 2, 2024 14:07
Copy link
Contributor

@eminalemdar eminalemdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe you can move this info box after the next paragraph.

@maxehio
Copy link
Contributor Author

maxehio commented Sep 3, 2024

LGTM but maybe you can move this info box after the next paragraph.

Your will shall be done m'lord

Copy link
Contributor Author

@maxehio maxehio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eminalemdar This look good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants