Remove obsolete documentation #342
Conversation
|
Your Render PR Server URL is https://spacelift-user-documentation-pr-342.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ck5fel021fec73clga3g. |
| @@ -18,80 +18,6 @@ resource "spacelift_stack" "managed-stack" { | |||
| } | |||
| ``` | |||
|
|
|||
| That's awesome. But can we put Terraform to good use and integrate it with resources from a completely different provider? Sure we can, and we have a good excuse, too. Stacks accessibility can be managed [by GitHub teams](../../concepts/stack/README.md#access-readers-and-writers-teams), so why don't we define some? | |||
There was a problem hiding this comment.
Don't we want to replace this with an up-to-date example instead of deleting it?
Without this, the "Taking it for a spin" section is underwhelming. 😄
There was a problem hiding this comment.
Can we point to the terraform starter guide on GitHub?
I think that's the only hands-on terraform guide that we have that guides you through using the Spacelift provider.
There was a problem hiding this comment.
Good idea. I hate duplicating content. 👍
|
|
||
| !!! success | ||
| OK, so who wants to go back to clicking on things in the web GUI? Because you will likely need to do some clicking, too, [at least with your first stack](terraform-provider.md#proposed-workflow). | ||
| A more in depth guide that will guide you through creating multiple types of Spacelift resources through Terraform can be found at [the terraform-starter repository](https://github.com/spacelift-io/terraform-starter). |
There was a problem hiding this comment.
I would suggest a slight edit, other than that it looks good to me.
| A more in depth guide that will guide you through creating multiple types of Spacelift resources through Terraform can be found at [the terraform-starter repository](https://github.com/spacelift-io/terraform-starter). | |
| A more in-depth guide to creating multiple types of Spacelift resources with Terraform can be found at [the terraform-starter repository](https://github.com/spacelift-io/terraform-starter){: rel="nofollow"}. |
| @@ -6,7 +6,7 @@ What would you say if you could manage Spacelift resources - that is [stacks](.. | |||
|
|
|||
| Our Terraform provider is open source and its [README](https://github.com/spacelift-io/terraform-provider-spacelift) always contains the latest available documentation. It's also distributed as part of our [Docker runner image](../../integrations/docker.md#standard-runner-image) and available through our [own provider registry](terraform-provider.md#how-it-works). The purpose of this article isn't as much to document the provider itself but to show how it can be used to incorporate Spacelift resources into your infra-as-code. | |||
|
|
|||
| So, without further ado, let's define a stack: | |||
| An example of a Spacelift stack being defined through Terraform: | |||
There was a problem hiding this comment.
Just a nit, this sentence comes across as a bit abrupt. The advantage of the "So, without further ado, ..." part was that it connected the example to the previous piece of text.
If you're going to reword it, I think it would need to be something like: "Here is an example showing how to define a Spacelift stack using Terraform".
Description of the change
These fields don't exist in the provider at this time.
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:
mainbranch.If the proposed change is ready to be merged, please request a review from
@spacelift-io/solutions-engineering. Someone will review and merge the pull request.Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇