Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spacectl/worker): allow draining/undraining of workers #84

Merged
merged 1 commit into from
Sep 2, 2022
Merged

feat(spacectl/worker): allow draining/undraining of workers #84

merged 1 commit into from
Sep 2, 2022

Conversation

jpJuni0r
Copy link
Contributor

@jpJuni0r jpJuni0r commented Aug 30, 2022 •
edited
Loading

Closes #68.

This was referenced Aug 31, 2022
Open
Closed
@peterdeme peterdeme self-requested a review August 31, 2022 16:03
@peterdeme
Copy link
Collaborator

Will review and test tomorrow.

@peterdeme
Copy link
Collaborator

@jpJuni0r I tested it locally, looks good to me. Just one minor thing, can you add some log output to both commands? something like fmt.Printf("Successfully drained worker %s\n", workerid)

peterdeme
peterdeme requested changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@peterdeme peterdeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the above comment

@jpJuni0r
Copy link
Contributor Author

jpJuni0r commented Sep 2, 2022

No problem. 😊

@jpJuni0r jpJuni0r requested a review from peterdeme September 2, 2022 07:43
@peterdeme peterdeme merged commit 08c6652 into spacelift-io:main Sep 2, 2022
@jpJuni0r jpJuni0r deleted the drain-worker branch September 2, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdeme peterdeme Awaiting requested review from peterdeme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: drain and undrain workers
2 participants
@jpJuni0r @peterdeme