Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roadmap updates #2209

Merged
merged 7 commits into from
Mar 16, 2024
Merged

Roadmap updates #2209

merged 7 commits into from
Mar 16, 2024

Conversation

jamiepine
Copy link
Member

Made a lot of improvements to the roadmap

@jamiepine jamiepine requested a review from a team as a code owner March 14, 2024 06:25
@jamiepine jamiepine enabled auto-merge March 14, 2024 06:26
@vercel Vercel
Copy link

vercel bot commented Mar 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
spacedrive-landing ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2024 0:16am
spacedrive-web ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2024 0:16am

@jamiepine
Copy link
Member Author

Need to verify the setup script docs I added have correct commands for brew and docker, if the reviewer could ensure that would be epic!

@Rocky43007
Copy link
Contributor

Rocky43007 commented Mar 15, 2024 •
edited
Loading

Homebrew command works fine. But the docker command fails:
Screenshot 2024-03-14 at 10 40 59 PM

Turns out, spacedrive/spacedrive doesn't exist on the Docker hub.
Screenshot 2024-03-14 at 10 42 43 PM

utkubakir and others added 2 commits March 15, 2024 05:53
@utkubakir
Update setup.mdx
ef70348
@Rocky43007
Update setup.mdx
56fc1c5 
Add Notice about possible Docker Warning that Spacedrive Server runs the best on Linux/amd64.

Also added a warning that mobile is not ready for public beta testing yet.
@brxken128
Copy link
Contributor

Homebrew command works fine. But the docker command fails: Screenshot 2024-03-14 at 10 40 59 PM

Turns out, spacedrive/spacedrive doesn't exist on the Docker hub. Screenshot 2024-03-14 at 10 42 43 PM

I think we actually use ghcr.io, allow me to check quickly

@Rocky43007
Copy link
Contributor

We do. Docs were updated to use ghcr.io instead of docker hub.

@brxken128
Copy link
Contributor

We do. Docs were updated to use ghcr.io instead of docker hub.

Beat me to it! I missed your commit and just saw the change as I went to edit it

@jamiepine jamiepine disabled auto-merge March 15, 2024 20:50
brxken128
brxken128 previously approved these changes Mar 15, 2024
View reviewed changes
brxken128
brxken128 approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@brxken128 brxken128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands, paths and grammar all look good to me!

@utkubakir utkubakir added this pull request to the merge queue Mar 16, 2024
Merged via the queue into main with commit a13a054 Mar 16, 2024
9 checks passed
@utkubakir utkubakir deleted the roadmap-changes branch March 16, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brxken128 brxken128 brxken128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamiepine @Rocky43007 @brxken128 @utkubakir