Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/post refactor fixes #927

Merged
merged 11 commits into from
Jan 12, 2023
Merged

Dev/post refactor fixes #927

merged 11 commits into from
Jan 12, 2023

Conversation

TheArcaneBrony
Copy link
Member

  • Move session id generation to connect
  • Reimplement logging of outgoing websocket data
  • Implement dumping gateway conversations to disk
  • Set user id for sentry on authorized routes (fixes user counts)

Copy link
Member

@MaddyUnderStars MaddyUnderStars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise seems fine, thanks

src/api/middlewares/Authentication.ts Show resolved Hide resolved
src/gateway/events/Connection.ts Show resolved Hide resolved
src/gateway/events/Message.ts Outdated Show resolved Hide resolved
src/gateway/util/Send.ts Outdated Show resolved Hide resolved
@MaddyUnderStars
Copy link
Member

It looks like prettier didn't run when you committed? what's up with that lol

@MaddyUnderStars MaddyUnderStars merged commit 1e1ba96 into master Jan 12, 2023
@MaddyUnderStars MaddyUnderStars deleted the dev/post-refactor-fixes branch January 12, 2023 12:47
erkinalp pushed a commit to erkinalp/spacebarchat-server that referenced this pull request Jan 14, 2023
* Re-introduce outgoing message logging

Signed-off-by: TheArcaneBrony <[email protected]>

* Websocket dumping

* Sentry user count on API

* Generate session ID upon opening websocket, fix gateway dumps

* Async file io in src/gateway/events/Message.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Async file io in src/util/util/Config.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Make pre-commit hook executable

Signed-off-by: TheArcaneBrony <[email protected]>

* Fixed sync file io in src/util/util/Config.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Fixed missing await call in src/util/util/AutoUpdate.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Add comment to src/gateway/events/Connection.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Clean up gateway dumping code

Signed-off-by: TheArcaneBrony <[email protected]>
Co-authored-by: Madeline <[email protected]>
MaddyUnderStars added a commit that referenced this pull request Mar 1, 2023
* Re-introduce outgoing message logging

Signed-off-by: TheArcaneBrony <[email protected]>

* Websocket dumping

* Sentry user count on API

* Generate session ID upon opening websocket, fix gateway dumps

* Async file io in src/gateway/events/Message.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Async file io in src/util/util/Config.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Make pre-commit hook executable

Signed-off-by: TheArcaneBrony <[email protected]>

* Fixed sync file io in src/util/util/Config.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Fixed missing await call in src/util/util/AutoUpdate.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Add comment to src/gateway/events/Connection.ts

Signed-off-by: TheArcaneBrony <[email protected]>

* Clean up gateway dumping code

Signed-off-by: TheArcaneBrony <[email protected]>
Co-authored-by: Madeline <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants