-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/post refactor fixes #927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheArcaneBrony
commented
Jan 11, 2023
- Move session id generation to connect
- Reimplement logging of outgoing websocket data
- Implement dumping gateway conversations to disk
- Set user id for sentry on authorized routes (fixes user counts)
MaddyUnderStars
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise seems fine, thanks
Signed-off-by: TheArcaneBrony <[email protected]>
Signed-off-by: TheArcaneBrony <[email protected]>
Signed-off-by: TheArcaneBrony <[email protected]>
Signed-off-by: TheArcaneBrony <[email protected]>
Signed-off-by: TheArcaneBrony <[email protected]>
Signed-off-by: TheArcaneBrony <[email protected]>
It looks like prettier didn't run when you committed? what's up with that lol |
MaddyUnderStars
approved these changes
Jan 12, 2023
erkinalp
pushed a commit
to erkinalp/spacebarchat-server
that referenced
this pull request
Jan 14, 2023
* Re-introduce outgoing message logging Signed-off-by: TheArcaneBrony <[email protected]> * Websocket dumping * Sentry user count on API * Generate session ID upon opening websocket, fix gateway dumps * Async file io in src/gateway/events/Message.ts Signed-off-by: TheArcaneBrony <[email protected]> * Async file io in src/util/util/Config.ts Signed-off-by: TheArcaneBrony <[email protected]> * Make pre-commit hook executable Signed-off-by: TheArcaneBrony <[email protected]> * Fixed sync file io in src/util/util/Config.ts Signed-off-by: TheArcaneBrony <[email protected]> * Fixed missing await call in src/util/util/AutoUpdate.ts Signed-off-by: TheArcaneBrony <[email protected]> * Add comment to src/gateway/events/Connection.ts Signed-off-by: TheArcaneBrony <[email protected]> * Clean up gateway dumping code Signed-off-by: TheArcaneBrony <[email protected]> Co-authored-by: Madeline <[email protected]>
MaddyUnderStars
added a commit
that referenced
this pull request
Mar 1, 2023
* Re-introduce outgoing message logging Signed-off-by: TheArcaneBrony <[email protected]> * Websocket dumping * Sentry user count on API * Generate session ID upon opening websocket, fix gateway dumps * Async file io in src/gateway/events/Message.ts Signed-off-by: TheArcaneBrony <[email protected]> * Async file io in src/util/util/Config.ts Signed-off-by: TheArcaneBrony <[email protected]> * Make pre-commit hook executable Signed-off-by: TheArcaneBrony <[email protected]> * Fixed sync file io in src/util/util/Config.ts Signed-off-by: TheArcaneBrony <[email protected]> * Fixed missing await call in src/util/util/AutoUpdate.ts Signed-off-by: TheArcaneBrony <[email protected]> * Add comment to src/gateway/events/Connection.ts Signed-off-by: TheArcaneBrony <[email protected]> * Clean up gateway dumping code Signed-off-by: TheArcaneBrony <[email protected]> Co-authored-by: Madeline <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.