Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase PHPStan level to 5 #20

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Increase PHPStan level to 5 #20

merged 5 commits into from
Jun 15, 2023

Conversation

milan-miscevic
Copy link

@milan-miscevic milan-miscevic commented Jun 5, 2023

Q A
Branch? main
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

This PR increases PHPStan level to 5 and fixes all errors.

@@ -213,7 +212,7 @@ public function iWaitSecondsUntilISeeInTheElement($count, $text, $element): void
} catch (StaleElementReference $e) {
// assume page reloaded whilst we were still waiting
}
} while (!$found && (time() - $startTime < $count));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always true.

@@ -98,7 +98,7 @@ public function theResponseShouldBeEmpty(): void
{
$actual = $this->request->getContent();
$message = "The response of the current page is not empty, it is: $actual";
$this->assertTrue(null === $actual || '' === $actual, $message);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milan-miscevic milan-miscevic changed the title Increase PHPStan level to 4 Increase PHPStan level to 5 Jun 5, 2023
@@ -8,9 +8,9 @@
class SystemContext implements Context
{
private $root;
private $output;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both properties were "is never written, only read".

@soyuka soyuka merged commit 0c7677f into soyuka:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants