Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.x
branch)The commit php-cs-fixer broke some steps definition in a few contexts.
The rule
doctrine_annotation_spaces
remove spaces around parentheses for Doctrine annotations but it works with a blacklist which is not includingGiven
,When
andThen
.It also introduced the
declare(strict_types=1);
which generates error in multiple places.For instance in the
DebugContext
there is:But
getTitle
returnsstring|null
because the title is optional, which generatesTypeError
exceptions hiding the real failure of the test.In
Asserter::assertContains()
we usepreg_quote
to perform the check but the expected value could be something else than a string and tests fails even though they were passing before.