Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package name is soyuka/contexts #13

Merged
merged 1 commit into from
Jan 20, 2023
Merged

package name is soyuka/contexts #13

merged 1 commit into from
Jan 20, 2023

Conversation

jdeniau
Copy link

@jdeniau jdeniau commented Dec 16, 2022

Q A
Branch? main
Bug fix? no
New feature? no
Deprecations? no
License MIT

@MirakuSan
Copy link

Maybe you can also change all namespace ?

Example : namespace Behatch\Context; becomes namespace Soyuka\Context;
What do you think?

@jdeniau
Copy link
Author

jdeniau commented Dec 21, 2022

It seems interesting for the next major release, but it's a way bigger change and will need a separate PR.
You may want to open an RFC issue about this.

@MirakuSan
Copy link

It seems the repo is not open for adding issues, @soyuka can you create an issue for the namespace or change the repository parameters so I can do it ?

@francisbesset
Copy link

If the namespace change, also soyuka/contexts cannot be keep the replace sanpi/behatch-contexts, or use class_alias() to keep backward compatibility.

@soyuka
Copy link
Owner

soyuka commented Jan 20, 2023

it's such a pain changing a namespace in PHP. IMO this is a no-go, I've talked with other maintainers and ppl that use behat, we maintain this because we need it but I'd like it to just stay a "maintained fork" and not really add new features, fix people issues etc. so not really up to opening issues here.

@soyuka soyuka merged commit 82dfbf4 into soyuka:main Jan 20, 2023
@jdeniau jdeniau deleted the patch-1 branch January 20, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants