PHP 8 by #12
Closed
PHP 8 by #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imum version of latest installable package. Code style update. All functions now have typed parameters and return types where this was possible. Added annotation for thrown errors if any. Class properties and interfaces also typed where immediately clear what they should be. Generic code styling applied (mainly spacing).
…fork origin and removed the '2' from Symfony2 from the description.
…was changed to harden code, but causes unintended side effects.
…) object in str_replace (requires string 3rd arg)
…n notice in JsonInspector
…ddHeaderEqualTo, but with different Gherkin
feat: added function theHeaderIsSetEqualTo, which does the same as iAddHeaderEqualTo, but with different Gherkin
…t. Replaced repetitive message string with constant.
feat: Added assertNull function in Asserter and applied in JsonContext. Replaced repetitive message string with constant.
…ode-name-in-exception Task fix upload file name and show node name in exception
| { | ||
| $regex = '/' . preg_quote($expected, '/') . '/ui'; | ||
| $regex = '/' . \preg_quote($expected, '/') . '/ui'; |
There was a problem hiding this comment.
please :)
Suggested change
| $regex = '/' . \preg_quote($expected, '/') . '/ui'; | |
| $regex = '/' . \preg_quote((string) $expected, '/') . '/ui'; |
|
Hi @soyuka, Apologies for never replying, I completely forgot about it. Not sure if this PR would still be relevant today, if it is, grab what you want :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rkeet just a todo PR I want to merge