Add compatibility fixes + some optimizations/modifications #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which also works on all linux distros worth speaking of, including NixOS.
Docker build context now also optimized! (No longer copy in the entire zip and potentially its unzipped contents).
Also: - re-factor out the `runuser` common flags - actually leverage the $DISPLAY env var (needs double-checking that works correctly)
…ne bash-isms No point/benefit using `[ <condition> ]` instead of `[[ <condition> ]]` when shebang specifies bash. Leverage opportunity to make cleaner one-liners, and moving long `&&` chained commands to each individual line
Only point to this will be if files inside of torch-server.zip belong to non-1000 uid user(s). This is not the case; ``` [2023-01-29 23:52:03] 127 x10an14@home-desktop:~/Documents/github/se-torchapi-linux -> $ find torch-server/ \! -user $USER -print [2023-01-29 23:52:18] 0 x10an14@home-desktop:~/Documents/github/se-torchapi-linux -> $ history | tail -n 3 36153 [2023-01-29 23:52:02] ./start 36154 [2023-01-29 23:52:18] find torch-server/ \! -user $USER -print 36155 [2023-01-29 23:52:27] history | tail -n 3 [2023-01-29 23:52:27] 0 x10an14@home-desktop:~/Documents/github/se-torchapi-linux -> $ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't necessarily work yet - hence draft.
See commit messages for changes and their motivation/intent.