Fix Ansible-lint E303 (kubernetes-sigs#6409)

southbridgeio · Jan 12, 2021 · 6df9710 · 6df9710
1 parent a50c890
commit 6df9710
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/roles/kubernetes/preinstall/handlers/main.yml b/roles/kubernetes/preinstall/handlers/main.yml
@@ -29,8 +29,10 @@
     - Preinstall | reload kubelet
   when: is_fedora_coreos
 
-- name: Preinstall | reload NetworkManager  # noqa 303
-  command: systemctl restart NetworkManager.service
+- name: Preinstall | reload NetworkManager
+  service:
+    name: NetworkManager.service
+    state: restarted
   when: is_fedora_coreos
 
 - name: Preinstall | reload kubelet

diff --git a/roles/kubernetes/preinstall/tasks/0040-set_facts.yml b/roles/kubernetes/preinstall/tasks/0040-set_facts.yml
@@ -31,7 +31,8 @@
   changed_when: false
   check_mode: no
 
-- name: check systemd-resolved  # noqa 303
+- name: check systemd-resolved
+  # noqa 303 Should we use service_facts for this?
   command: systemctl is-active systemd-resolved
   register: systemd_resolved_enabled
   failed_when: false

diff --git a/roles/network_plugin/calico/tasks/install.yml b/roles/network_plugin/calico/tasks/install.yml
@@ -6,7 +6,8 @@
     mode: 0755
     remote_src: yes
 
-- name: Calico | Check if host has NetworkManager  # noqa 303
+- name: Calico | Check if host has NetworkManager
+  # noqa 303 Should we use service_facts for this?
   command: systemctl show NetworkManager
   register: nm_check
   failed_when: false