Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight :foo? and 10_000 correctly #1

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Highlight :foo? and 10_000 correctly #1

merged 1 commit into from
Dec 19, 2023

Conversation

sampersand
Copy link
Collaborator

@sampersand sampersand commented Dec 19, 2023 •
edited
Loading

Currently, :foo? highlights as an optional :foo, not the symbol :foo?. Additionally, 10_000 breaks and only highlights 000.

@sampersand sampersand force-pushed the swesterman/23-12-18/update-ints-and-symbols branch from f966146 to 7aa1e45 Compare December 19, 2023 00:52
soutaro
soutaro approved these changes Dec 19, 2023
View reviewed changes
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro merged commit ca97cb8 into main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampersand @soutaro