Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Part 2 #140

Merged
merged 10 commits into from
Apr 12, 2017
Merged

Rewrite Part 2 #140

merged 10 commits into from
Apr 12, 2017

Conversation

shortdudey123
Copy link
Contributor

@shortdudey123 shortdudey123 commented Apr 12, 2017 •
edited
Loading

  • Mainly updating the user management to work w/ 2.x mongo gem as well as the existing code for 1.x
  • Cleanup all deprecation warnings as well

Closes #119

@shortdudey123 shortdudey123 requested review from damacus and tas50 April 12, 2017 03:39
@shortdudey123 shortdudey123 mentioned this pull request Apr 12, 2017
Closed
@shortdudey123
Restrict user kitchen testing to one OS
d3583b2 
```
$ chef exec kitchen list user
Instance                             Driver   Provisioner  Verifier  Transport  Last Action    Last Error
user-management-centos-73            Vagrant  ChefSolo     Inspec    Ssh        <Not Created>  <None>
user-management-v2-centos-73         Vagrant  ChefSolo     Inspec    Ssh        <Not Created>  <None>
user-management-v2-delete-centos-73  Vagrant  ChefSolo     Inspec    Ssh        <Not Created>  <None>
$
```
damacus
damacus reviewed Apr 12, 2017
View reviewed changes
.travis.yml
@@ -15,6 +15,7 @@ install: echo "skip bundle install"
branches:
only:
- master
- rewrite_v1

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

damacus
damacus approved these changes Apr 12, 2017
View reviewed changes
test/integration/user_management_v2/inspec/user_management_spec.rb
@@ -0,0 +1,29 @@
# @test "requires authentication" {

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

@damacus damacus merged commit 57b1ee5 into rewrite_v1 Apr 12, 2017
@shortdudey123 shortdudey123 deleted the rewrite_part2 branch April 12, 2017 08:57
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damacus damacus damacus approved these changes

@tas50 tas50 Awaiting requested review from tas50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortdudey123 @damacus