Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ntpsec use a compatible Apparmor configuration (#257) #258

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

ahpnils
Copy link
Contributor

@ahpnils ahpnils commented Jan 29, 2025

Description

Introduces a ntpsec compatible Apparmor configuration, and uses it.

Issues Resolved

#257 but it could help for #254 .

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@ahpnils ahpnils marked this pull request as ready for review January 30, 2025 08:18
@ahpnils ahpnils requested a review from a team as a code owner January 30, 2025 08:18
@damacus
Copy link
Member

damacus commented Jan 30, 2025

Can you try and get The ubuntu suites working, we know this change is OK to ship.

@ahpnils ahpnils force-pushed the fix_ntpsec_apparmor branch from 7e6587e to 0f6dc98 Compare January 31, 2025 08:46
@ahpnils
Copy link
Contributor Author

ahpnils commented Jan 31, 2025

@damacus 0f6dc98 worked on my local Dokken setup, but the CI fails because of Apparmor. From what I see, it looks like the underlying kernel does not support Apparmor. This test is not enough. When Apparmor is enabled, /sys/module/apparmor/parameters/enabled is available and contains Y.

@damacus damacus merged commit 188e6af into sous-chefs:main Jan 31, 2025
21 of 26 checks passed
@damacus
Copy link
Member

damacus commented Jan 31, 2025

Ok I'll go with your local dokken instance. If you can figure out CI that would be super useful.

@ahpnils
Copy link
Contributor Author

ahpnils commented Jan 31, 2025

@damacus you would have waited 5 min before merging this PR you would have got it, I think. I'll open a new PR.

@damacus
Copy link
Member

damacus commented Jan 31, 2025

😂 brilliant 👍

Apologies for being hot off the gun there.

Merging whilst taking care of a sick kid at home!

@ahpnils
Copy link
Contributor Author

ahpnils commented Jan 31, 2025

No worries, sick kid comes first !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants