Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unified mode #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

axl89
Copy link

@axl89 axl89 commented Oct 1, 2021

Description

Enabled unified mode, since it'll be the default mode on Chef Infra Client 18.x

Issues Resolved

N/A

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

axl89 added 2 commits October 1, 2021 17:54
It will be the default behavior for Chef Infra Client 18.x
@axl89 axl89 requested a review from a team as a code owner October 1, 2021 15:56
Copy link
Contributor

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think making this change is coupled to the minimum version of chef this cookbook supports which is currently 12. This change breaks clients < 15.3 if I understand correctly.

chef_version '>= 12.15'

@ramereth
Copy link
Contributor

ramereth commented Oct 3, 2021

I'd like to hold on doing this until we get it properly adopted by Sous Chefs. It's been on my to-do list for a while and had started a clean up locally.

@damacus damacus added hacktoberfest-accepted PR has been accepted for hacktoberfest 2020. Waiting on merge On Hold Work has been started but is not actively being developed labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR has been accepted for hacktoberfest 2020. Waiting on merge On Hold Work has been started but is not actively being developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants