Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value of "leases" attribute #60

Merged
merged 1 commit into from
May 17, 2016

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented May 17, 2016

It fixes an error:

           ================================================================================
           Error executing action `read` on resource 'vault_secret[secret/secretpath]'
           ================================================================================

           TypeError
           ---------
           no implicit conversion of String into Integer

           Cookbook Trace:
           ---------------
           /tmp/kitchen/cache/cookbooks/hashicorp-vault/libraries/vault_secret.rb:66:in `[]'
           /tmp/kitchen/cache/cookbooks/hashicorp-vault/libraries/vault_secret.rb:66:in `block (2 levels) in <class:VaultSecret>'
           /tmp/kitchen/cache/cookbooks/poise/files/halite_gem/poise/helpers/subcontext_block.rb:54:in `instance_eval'
           /tmp/kitchen/cache/cookbooks/poise/files/halite_gem/poise/helpers/subcontext_block.rb:54:in `subcontext_block'
           /tmp/kitchen/cache/cookbooks/poise/files/halite_gem/poise/helpers/notifying_block.rb:67:in `notifying_block'
           /tmp/kitchen/cache/cookbooks/hashicorp-vault/libraries/vault_secret.rb:60:in `block in <class:VaultSecret>'

That was my bad, introduced by #56. I'm sorry 😞

Otherwise it fails on the next line
@Ginja
Copy link
Contributor

Ginja commented May 17, 2016

👍

@Ginja Ginja merged commit 3c436b0 into sous-chefs:master May 17, 2016
@legal90 legal90 deleted the fix_leases_default branch May 17, 2016 15:47
@lock
Copy link

lock bot commented May 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants