Add support for EC2 discovery type's instance tag constraints. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `aws` data bag can now have a structure at `discovery.ec2.tag` that contains EC2 instance tag values keyed by tag name. Any tag specified will be required for an EC2 instance to be discoverable by the plugin.
|
Hi, retouched it a bit and merged, thanks! Since knife-ec2 supports tagging nodes now as well, maybe we could also use those, but it would need extensive checking. Also note, in the current version, you can set |
karmi
added a commit
that referenced
this pull request
Mar 6, 2013
karmi
added a commit
that referenced
this pull request
Mar 6, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
awsdata bag can now have a structure atdiscovery.ec2.tagthat contains EC2 instance tag values keyed by tag name. Any tag specified will be required for an EC2 instance to be discoverable by the plugin.