Additional Logging Options - Ubuntu Init Scripts #152
Conversation
…stic search plugins field.
…m/remkade/cookbook-elasticsearch with some minor changes to the ubuntu script.
Conflicts: attributes/plugins.rb
|
@karmi Also, an update on the need for the Ubuntu specific Init script - chef doesn't find Ubuntu servers as Debian. So we need an Ubuntu specific folder to ensure it gets pulled. I pulled the Debian script from Kyle's repo and then needed to make some small modifications for Ubuntu. I left the Debian script as Kyle's repo had it. |
…per cookbook" pattern Resources: * http://dougireton.com/blog/2013/02/16/chef-cookbook-anti-patterns/ * http://realityforge.org/code/2012/11/19/role-cookbooks-and-wrapper-cookbooks.html * http://stackoverflow.com/questions/15933157/replacing-a-template-in-a-wrapper-cookbook/15935161#15935161 Related: #152
…per cookbook" pattern Resources: * http://dougireton.com/blog/2013/02/16/chef-cookbook-anti-patterns/ * http://realityforge.org/code/2012/11/19/role-cookbooks-and-wrapper-cookbooks.html * http://stackoverflow.com/questions/15933157/replacing-a-template-in-a-wrapper-cookbook/15935161#15935161 Related: #152
|
Hi, about adding more logging options: I think this is quite near the line where you want to completely change the stock template, not dissect it with myriads of configuration options. One of the reasons Chef is such a powerful provisioning system is the fact that it's "all Ruby", and you can significantly modify the resources and configurations in code. I've added quite verbose information about creating a "wrapper cookbook" in 387b04d, and advise to look into that. Regarding the init scripts, I apologize, but I simply won't merge any "let's tweak the init scripts a bit more" patches --unless they fix a clearly replicable, simple bugs. I've stated previously that I want us to improve installing from official .deb/.rpm to be on par with the "download/extract" approach. Also, with the "wrapper cookbook" pattern, it's dead simple to replace the init script with a custom one. |
|
@karmi Hey Karel! I appreciate the time you took in response. I totally understand your point. I'll get on creating a wrapper now, thanks for the knowledge transfer! |
Sorry, didn't think we were going to get the init scripts added so soon so committed to my repository so I could have a working impl for our environment. Originally, I just wanted to create a pull request for the Logging Options only. If you feel we don't want the init scripts I can remove them temporarily so we can get the logging options committed. Please advise.
Also, thanks for being so proactive on this project - Karel you do awesome work!