Monit issues (template file name, internal issues)

[ryan-roemer]

First of all, I wanted to say: great cookbook! I've been hacking around with various other ElasticSearch cookbooks, and this was the only one that was current, works with AWS, and doesn't drag in a whole mess of other dependencies.

One thing I found on initially running the recipe is that the Monit conf template is "elasticsearch.monitrc.erb", but the monitrc recipe (v0.6) has a hard-coded assumption of "#{name}.conf.erb". I ended up renaming "elasticsearch.monitrc.erb" to "elasticsearch.conf.erb" to get past it, but I don't particularly like my solution as "elasticsearch.conf.erb" sounds too general.

Here's my exception:

[Fri, 09 Mar 2012 20:25:41 +0000] ERROR: template[/etc/monit/conf.d/elasticsearch.conf] (/var/cache/chef/cookbooks/monit/libraries/monitrc.rb:8:in `monitrc') had an error:
template[/etc/monit/conf.d/elasticsearch.conf] (elasticsearch::default line 8) had an error: Chef::Exceptions::FileNotFound: Cookbook 'elasticsearch' (0.0.1) does not contain a file at any of these locations:
  templates/ubuntu-11.10/elasticsearch.conf.erb
  templates/ubuntu/elasticsearch.conf.erb
  templates/default/elasticsearch.conf.erb

Also, I get an error for this line in the monit conf:

http://<%= node.monit[:http_auth]['username'] %>:<%= node.monit[:http_auth]['password_encoded'] %>@<%= node.cloud.public_hostname %>:2812/elasticsearch_cluster_health

Skimming the monit recipe, I don't see an http_auth attribute anywhere.

[karmi]

Argh, you're right -- this has slipped me, because we have a customized Monit cookbook which uses *.monitrc (we think it's a better naming). I think we should bend to monit cookbook's will here, though :/

The http_auth issue is again related to our particular setup, where we have a HTTP authentication setup for the Monit web frontend -- this is clearly bad. I'll fix the cookbok to work with the stock Monit recipe!

Glad that the cookbook is useful, thanks! :)

[karmi]

Ryan, check the fix, please -- works locally with Vagrant and stock Monit cookbook.

[karmi]

Also, could you please check the setup with 90ed2a1? It contains a fix for proper installation of the cloud-aws plugin on ES 0.19.

[ryan-roemer]

Hi Karel,

Thanks for the rapid turnaround! I won't be able to check things in code until this weekend or Monday, but it looks correct on inspection. I also separately ran into the cloud-aws plugin issue and your fix looks analogous to what I did (sorry, I didn't have a chance to wrap it up in an issue yet). I'll report back for sure when I run it through my staging system.

Thanks again,
Ryan

[karmi]

Hi Ryan, no rush, and thanks!

[ryan-roemer]

Updated and deployed. Everything looks good. Thanks Karel!

[karmi]

While investigating Monit issues, pushed 42db58c -- the Monit integration actually has been relying on default template location/filename. Should work now -- added a test to Vagrant as well.