Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin resource's plugin_dir should have a sensible default #345

Closed
michaelklishin opened this issue Jul 16, 2015 · 1 comment · Fixed by #349
Closed

Plugin resource's plugin_dir should have a sensible default #345

michaelklishin opened this issue Jul 16, 2015 · 1 comment · Fixed by #349
Milestone
1.0.x bugfix release

Comments

@michaelklishin
Copy link
Contributor

README examples and even code comments use usr/local/awesome/elasticsearch-version/plugins as a plugin_dir value. I'm not sure if that's a real world example or not. Surely ElasticSearch provides a standard plugins directory: why doesn't this cookbook have a default for that? Why do the users have to even think about where to put the plugins?
@martinb3
Copy link
Contributor

Have you tried to use the elasticsearch_plugin with the defaults? It actually does default to the typical path. This cookbook was written to handle a very commonly requested case of multiple instances per server. We'll try to provide better documentation in the future.

@martinb3 martinb3 mentioned this issue Jul 16, 2015
Closed
@martinb3 martinb3 added this to the 1.0.x bugfix release milestone Jul 16, 2015
martinb3 added a commit that referenced this issue Jul 17, 2015
@martinb3
Test simple plugin install as part of default
0d8b627 
- Test default simple plugin install as part of default test suite.
- Add example using the test to the documentation. Add more simple examples to the README.md, demonstrating the defaults. RE: #345
@martinb3 martinb3 mentioned this issue Jul 17, 2015
Closed
martinb3 added a commit that referenced this issue Jul 17, 2015
@martinb3
Test simple plugin install as part of default
78cabea 
- Test default simple plugin install as part of default test suite.
- Add example using the test to the documentation. Add more simple examples to the README.md, demonstrating the defaults. RE: #345
@michaelklishin michaelklishin mentioned this issue Jul 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.x bugfix release
Development

Successfully merging a pull request may close this issue.

Clarify when overriding plugin_dir is necessary michaelklishin/cookbook-elasticsearch
2 participants
@michaelklishin @martinb3