Fix #164 - When using 7zip to extract with strip_components >= 1 (default is 1) extracts to home_dir, not path #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… >= 1 (default is 1) extracts to home_dir, not path Signed-off-by: Christopher Williams <[email protected]>
Signed-off-by: Christopher Williams <[email protected]>
sgtcoolguy
force-pushed
the
issue-164
branch
from
03c8cb0 to
4538608
Compare
This was referenced Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When extracting a 7zip file with strip_components >= 1, now correctly extracts to resource.path (which ultimately is win_install_dir on Windows).
Also fixes to force overwrite without prompting on extracting non-tar files (i.e. *.7z files).
Issues Resolved
Check List