Move tar/7zip path logic out of attributes and into helpers #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents failures on Windows when 7zip doesn’t exist at the beginning of the run Signed-off-by: Tim Smith <[email protected]>
tas50
force-pushed
the
fix_7zip_failure
branch
from
f4a0ee2 to
5faf2a0
Compare
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
|
Looks like it's just failing due to sevenzip_command_builder.run_context being undefined in the test environment. No idea how to fix that myself, but I'd love to see this bug fix get merged/released so the cookbook works on Windows again. |
|
It's in need of some love. I'm working on it. |
…messaging Signed-off-by: Tim Smith <[email protected]>
tas50
force-pushed
the
fix_7zip_failure
branch
from
a86e9ea to
3bdfb63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add windows to the readme as a supported platform
Move path determination of 7zip out of the attributes since this happens at compile time before we can ever install 7zip. This would always fail.