Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sra_search does not downsample subject sketches #6

Closed
ctb opened this issue Sep 22, 2022 · 1 comment
Closed

sra_search does not downsample subject sketches #6

ctb opened this issue Sep 22, 2022 · 1 comment

Comments

@ctb
Copy link
Contributor

ctb commented Sep 22, 2022

Over in https://github.com/ctb/magsearch, I added a --scaled parameter to our runtime workflow to make the query signature scaled value configurable, in an attempt to deal with #2 and #4.

This results in the following output:

thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', src/main.rs:131:29

that is issued once for each subject signature. So I'm pretty sure that (at the moment) the query signatures, --scaled argument, and subject signatures all need to be identical for sra_search to run properly.

It would be nice if when --scaled was specified, all the signatures were downsampled to that scaled, with sra_search outputting an error when that can't happen.
@ctb ctb mentioned this issue Sep 22, 2022
Closed
@luizirber luizirber mentioned this issue Oct 2, 2022
Merged
luizirber added a commit that referenced this issue Oct 2, 2022
@luizirber
Downsampling (#12)
3253ffe 
Fixes #4 #6
Closes #10 

Bring a few bits from sourmash-bio/sourmash#2230
to support the proper query config (scaled considering downsampling,
both of queries and DB sigs).
@ctb
Copy link
Contributor Author

ctb commented Oct 2, 2022

it looks like this was fixed in #12.

@ctb ctb closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb