Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: support multiple input files for singlesketch #579

Merged
merged 1 commit into from
Jan 9, 2025
Merged

MRG: support multiple input files for singlesketch #579

merged 1 commit into from
Jan 9, 2025

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Jan 9, 2025

Fixes #535

@ctb
Copy link
Collaborator Author

ctb commented Jan 9, 2025

@bluegenes curious what you think - is it really this easy? 😆

bluegenes
bluegenes approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see you like the buildutils 😄. Lgtm 🎉

Yes - as usual, it's "easy" after many months of dedicated effort!

@ctb ctb merged commit e28c29a into main Jan 9, 2025
3 checks passed
@ctb ctb deleted the singlesketch_multifile branch January 9, 2025 14:36
This was referenced Jan 9, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluegenes bluegenes bluegenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can we allow singlesketch to take multiple input files?
2 participants
@ctb @bluegenes